MemSet incorrect copy for native float array with -1#1361
Merged
chakrabot merged 2 commits intochakra-core:masterfrom Aug 12, 2016
Merged
MemSet incorrect copy for native float array with -1#1361chakrabot merged 2 commits intochakra-core:masterfrom
chakrabot merged 2 commits intochakra-core:masterfrom
Conversation
Contributor
Author
Cellule
force-pushed
the
memop_setsamebytes
branch
2 times, most recently
from
618b3fd to
4faa24a
Compare
Contributor
Author
|
I realized that there were other occurrences of this bug. |
Contributor
…a byte level memset. This was valid ints but not for floats. Changed the check to really see if the bytes are all the same
Cellule
force-pushed
the
memop_setsamebytes
branch
from
4faa24a to
e961167
Compare
Contributor
|
|
chakrabot
pushed a commit
that referenced
this pull request
Aug 12, 2016
…ith -1 Merge pull request #1361 from Cellule:memop_setsamebytes We used to check if the memset value is -1 to determine if we can do a byte level memset. This was valid ints but not for floats. Changed the check to really see if the bytes are all the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to check if the memset value is -1 to determine if we can do a byte level memset.
This was valid ints but not for floats.
Changed the check to really see if the bytes are all the same.
This change is